Messages in this thread | | | Date | Sun, 18 Nov 2007 09:18:28 -0800 | From | Arjan van de Ven <> | Subject | Re: [patch] Printk kernel version in WARN_ON |
| |
On Sat, 17 Nov 2007 16:57:19 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> > Should be done for all architectures, methinks. > > If so, an appropriate way to do that would be to do > s/dump_stack/arch_dump_stack/ and do a single all-arch implementation > of dump_stack(). (Where we might add new goodies in the future). > > Problem is that this will add a new an pointless entry to all the > stack dumps, unless the arch_dump_stack() implementation is smart > enough to skip the innermost frame.
it also adds a stackframe to the "oh my god I'm low on stack space lets get a dump out" codepath ;(
>
-- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |