Messages in this thread | | | Date | Sun, 18 Nov 2007 02:04:08 +0100 | From | Ingo Molnar <> | Subject | Re: [patch] Printk kernel version in WARN_ON |
| |
* Andrew Morton <akpm@linux-foundation.org> wrote:
> Should be done for all architectures, methinks. > > If so, an appropriate way to do that would be to do > s/dump_stack/arch_dump_stack/ and do a single all-arch implementation > of dump_stack(). (Where we might add new goodies in the future).
i agree we can clean this up - but this is a single-line thing that is very useful for QA so i think utility warrants .24 inclusion. The oops printouts are not generalized anyway.
> Problem is that this will add a new an pointless entry to all the > stack dumps, unless the arch_dump_stack() implementation is smart > enough to skip the innermost frame.
x86 can skip stackframes via stacktrace.c.
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |