Messages in this thread | | | Date | 3 Oct 2006 12:37:40 +0200 | Date | Tue, 3 Oct 2006 12:37:40 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 1/6] Generic implemenatation of BUG. |
| |
> Because powerpc also records the function name, I added this to i386 and > x86-64 for consistency. Strictly speaking the function name is redundant with > kallsyms, so perhaps it can be dropped from powerpc.
It would be good to change it to use kallsyms() then.
> > #ifdef CONFIG_BUG > + > +#ifdef CONFIG_GENERIC_BUG > +struct bug_entry { > + unsigned long bug_addr; > +#ifdef CONFIG_DEBUG_BUGVERBOSE > + const char *file; > + unsigned short line; > +#endif > + unsigned short flags;
Can't you put the flags into the high bits of the line? I don't think we have any 64kLOC files.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |