lkml.org 
[lkml]   [2006]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] Generic implemenatation of BUG.
Andi Kleen wrote:
>> Because powerpc also records the function name, I added this to i386 and
>> x86-64 for consistency. Strictly speaking the function name is redundant with
>> kallsyms, so perhaps it can be dropped from powerpc.
>>
>
> It would be good to change it to use kallsyms() then.
>

It does, in effect, when it prints the oops message and backtrace.

>>
>> #ifdef CONFIG_BUG
>> +
>> +#ifdef CONFIG_GENERIC_BUG
>> +struct bug_entry {
>> + unsigned long bug_addr;
>> +#ifdef CONFIG_DEBUG_BUGVERBOSE
>> + const char *file;
>> + unsigned short line;
>> +#endif
>> + unsigned short flags;
>>
>
> Can't you put the flags into the high bits of the line? I don't think
> we have any 64kLOC files.

I thought about it, but it would still be padded out to 12 bytes on
i386, and more on 64-bit platforms. And it doesn't matter that much.


J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-03 17:55    [W:0.021 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site