Messages in this thread Patch in this message | | | Date | Mon, 23 Jan 2006 13:31:21 -0200 | From | Luiz Fernando Capitulino <> | Subject | [PATCH] slab: Adds two missing kmalloc() checks. |
| |
Adds two missing kmalloc() checks in kmem_cache_init(). The check is worth because if kmalloc() fails we'll have a nice message instead of a OOPS (which will make us look for a bug).
We're using BUG_ON() so that embedded people can disable it.
Signed-off-by: Luiz Capitulino <lcapitulino@mandriva.com.br>
mm/slab.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/mm/slab.c b/mm/slab.c index 6f8495e..2fcfd08 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -1130,6 +1130,7 @@ void __init kmem_cache_init(void) void *ptr; ptr = kmalloc(sizeof(struct arraycache_init), GFP_KERNEL); + BUG_ON(!ptr); local_irq_disable(); BUG_ON(ac_data(&cache_cache) != &initarray_cache.cache); @@ -1139,6 +1140,7 @@ void __init kmem_cache_init(void) local_irq_enable(); ptr = kmalloc(sizeof(struct arraycache_init), GFP_KERNEL); + BUG_ON(!ptr); local_irq_disable(); BUG_ON(ac_data(malloc_sizes[INDEX_AC].cs_cachep)
-- Luiz Fernando N. Capitulino - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |