lkml.org 
[lkml]   [2006]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] slab: Adds two missing kmalloc() checks.
From
Date
On Mon, 2006-01-23 at 18:38 +0200, Pekka Enberg wrote:
> Hi,
>
> On Mon, 2006-01-23 at 13:31 -0200, Luiz Fernando Capitulino wrote:
> > Adds two missing kmalloc() checks in kmem_cache_init(). The check is worth
> > because if kmalloc() fails we'll have a nice message instead of a OOPS (which
> > will make us look for a bug).
> >
> > We're using BUG_ON() so that embedded people can disable it.
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@mandriva.com.br>
>
> Looks good to me. Arjan, you had some objections last time around. Are
> you okay with the change?

I still fail to see the point. Has anyone EVER seen these trigger????


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-01-23 17:47    [W:0.040 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site