| Date | Sun, 10 Jul 2005 20:08:07 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] [38/48] Suspend2 2.1.9.8 for 2.6.12: 614-plugins.patch |
| |
Hi!
> +unsigned long suspend2_powerdown_method = 5; /* S5 = off */
Constants.....
> + if (suspend2_powerdown_method == 3 || > + suspend2_powerdown_method == 4)
Constants...
> + if (suspend2_powerdown_method == 3 || > + suspend2_powerdown_method == 4)
Constants...
> + suspend2_prepare_status(1, 0, "Ready to reboot."); > + suspend2_prepare_status(1, 0, "Seeking to enter ACPI state"); > + suspend2_prepare_status(1, 0, "Preparing to enter ACPI state failed. Using normal powerdown."); > + suspend2_prepare_status(1, 0, "Suspending devices failed. Using normal powerdown."); > + suspend2_prepare_status(1, 0, "Entering ACPI state failed. Using normal powerdown."); > + suspend2_prepare_status(1, 0, "Powering down.");
Too many magical constants here... Plus I don't really like your own logging subsystem. Pavel -- teflon -- maybe it is a trademark, but it should not be. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|