Messages in this thread | | | Date | Sat, 14 Aug 2004 19:29:32 +0100 | From | Matthew Wilcox <> | Subject | VPD in sysfs |
| |
I've been sent a patch that reads some VPD from the Symbios NVRAM and displays it in sysfs. I'm not sure whether the way the author chose to present it is the best. They put it in 0000:80:01.0/host0/vpd_name which seems a bit too scsi-specific and insufficiently forward-looking (I bet we want to expose more VPD data than that in the future, so we should probably use a directory).
I actually have a feeling (and please don't kill me for saying this), that we should add a struct vpd * to the struct device. Then we need something like the drivers/base/power/sysfs.c file (probably drivers/base/vpd.c) that takes care of adding vpd to each device that wants it.
Thoughts? Since there's at least four and probably more ways of getting at VPD, we either need to fill in some VPD structs at initialisation or have some kind of vpd_ops that a driver can fill in so the core can get at the data.
-- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |