Messages in this thread Patch in this message | | | Subject | [PATCH] Fix ppc64 out_be64 | From | Roland Dreier <> | Date | 12 Jun 2004 15:00:58 -0700 |
| |
I notice that the latest BK has a fix for the bugs in ppc64's out_le64 that I just spent a few hours tracking down in 2.6.6, but out_be64 is still broken.
This patch fixes two problems with out_be64: - The val parameter has to be unsigned long (not int), since it's 64 bits. - Since we're passing *addr into the asm as an output parameter, we should just use %0 instead of 0(%0) -- what's written won't even compile.
My ppc64 asm skills are nearly nonexistent but I'm pretty sure this fix is needed and correct.
Thanks, Roland
Signed-off-by: Roland Dreier <roland@topspin.com>
===== include/asm-ppc64/io.h 1.18 vs edited ===== --- 1.18/include/asm-ppc64/io.h 2004-05-21 00:50:11 -07:00 +++ edited/include/asm-ppc64/io.h 2004-06-12 14:55:49 -07:00 @@ -356,9 +356,9 @@ : "=&r" (tmp) , "=&r" (val) : "1" (val) , "b" (addr) , "m" (*addr)); } -static inline void out_be64(volatile unsigned long *addr, int val) +static inline void out_be64(volatile unsigned long *addr, unsigned long val) { - __asm__ __volatile__("std %1,0(%0); sync" : "=m" (*addr) : "r" (val)); + __asm__ __volatile__("std %1,%0; sync" : "=m" (*addr) : "r" (val)); } #ifndef CONFIG_PPC_ISERIES - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |