Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Fix ppc64 out_be64 | From | Benjamin Herrenschmidt <> | Date | Sun, 13 Jun 2004 10:50:22 -0500 |
| |
> -static inline void out_be64(volatile unsigned long *addr, int val) > +static inline void out_be64(volatile unsigned long *addr, unsigned long val) > { > - __asm__ __volatile__("std %1,0(%0); sync" : "=m" (*addr) : "r" (val)); > + __asm__ __volatile__("std %1,%0; sync" : "=m" (*addr) : "r" (val)); > }
Ugh ? The syntax of std is std rS, ds(rA), so your fix doesn't look good to me, and it definitely builds with the current syntax, though I agree the type is indeed wrong. I also spotted another bug where we forgot to change an eieio into sync in there though.
Does this totally untested patch works for you ?
===== include/asm-ppc64/io.h 1.18 vs edited ===== --- 1.18/include/asm-ppc64/io.h 2004-05-21 02:50:11 -05:00 +++ edited/include/asm-ppc64/io.h 2004-06-12 19:01:41 -05:00 @@ -307,7 +307,7 @@ static inline void out_be32(volatile unsigned *addr, int val) { - __asm__ __volatile__("stw%U0%X0 %1,%0; eieio" + __asm__ __volatile__("stw%U0%X0 %1,%0; sync" : "=m" (*addr) : "r" (val)); } @@ -358,7 +358,7 @@ static inline void out_be64(volatile unsigned long *addr, int val) { - __asm__ __volatile__("std %1,0(%0); sync" : "=m" (*addr) : "r" (val)); + __asm__ __volatile__("std%U0%X0 %1,%0; sync" : "=m" (*addr) : "r" (val)); } #ifndef CONFIG_PPC_ISERIES
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |