Messages in this thread | | | Subject | Re: [PATCH] s390 update (4/9): common i/o layer update. | From | "Martin Schwidefsky" <> | Date | Wed, 26 Mar 2003 17:27:23 +0100 |
| |
> > + typeof (chsc_area_ssd.response_block) > > + *ssd_res = &chsc_area_ssd.response_block; > > Yikes! Please use the actual type here instead of typeof() Trouble is that response_block is an anonymous structure. There is not type...
> > + if (sch->lpm == 0) > > + return -ENODEV; > > + else > > + return -EACCES; > > I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm > just too picky.. No, you are not. return (sch->lpm ? -EACCES : -ENODEV) is better.
> > - sch = kmalloc (sizeof (*sch), GFP_DMA); > > + sch = kmalloc (sizeof (*sch), GFP_KERNEL | GFP_DMA); > > What about using GFP_KERNEL | __GFP_DMA instead? This makes it > more clear that it's just a qualifier. Hmm, GFP_DMA and __GFP_DMA are equivalent. I don't quite see your point here.
blue skies, Martin
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |