Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 26 Mar 2003 17:37:32 +0100 | From | Jörn Engel <> | Subject | Re: [PATCH] s390 update (4/9): common i/o layer update. |
| |
On Wed, 26 March 2003 17:27:23 +0100, Martin Schwidefsky wrote: > > > > + if (sch->lpm == 0) > > > + return -ENODEV; > > > + else > > > + return -EACCES; > > > > I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm > > just too picky.. > No, you are not. return (sch->lpm ? -EACCES : -ENODEV) is better.
Are the brackets really necessary? This is highly personal, but I spend a few second "stubling" over them, which makes the code less readable for me.
Jörn
-- With a PC, I always felt limited by the software available. On Unix, I am limited only by my knowledge. -- Peter J. Schoenster - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |