Messages in this thread | | | Date | Wed, 8 Oct 2003 12:50:51 +0100 | From | Dave Jones <> | Subject | Re: [PATCH] Poll-based IDE driver |
| |
On Wed, Oct 08, 2003 at 03:13:57PM +0530, Srivatsa Vaddagiri wrote:
> /* Wait for at least N usecs (1 clock per cycle, 10GHz processor = 10000) */ > /* ToDo : replace this routine based on loops_per_jiffy?? */ > static inline void dump_udelay(unsigned int num_usec) > { > volatile unsigned int i; > for (i = 0; i < 10000 * num_usec; i++); > }
Why not just use udelay() ? The above code cannot possibly do the right thing on all processors.
Dave
-- Dave Jones http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |