Messages in this thread | | | Date | Wed, 8 Oct 2003 13:15:23 +0100 | From | Dave Jones <> | Subject | Re: [PATCH] Poll-based IDE driver |
| |
On Wed, Oct 08, 2003 at 05:44:58PM +0530, Srivatsa Vaddagiri wrote:
> > Why not just use udelay() ? The above code cannot possibly do > > the right thing on all processors. > > Since my code is supposed to run when system is crashing, I would like > to avoid calling any function in the kernel as far as possible, since > the kernel and its data structures may be in a inconsistent state > and/or corrupted.
By the same principle, your dump_udelay() is just as likely to get stomped on as the kernels udelay() function.
> I do realize that the above code does not provide accurate > delay and may not work on all platforms. In that direction > I was considering using the loops_per_jiffy variable > which may provide more accurate/platform-independent delay (?) ..
If you must reinvent a wheel, use a round one. Copy udelay().
Dave
-- Dave Jones http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |