lkml.org 
[lkml]   [1999]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectBogus serialP.h patch?
From

Umm, the following patch in 2.3.25 is bogus. SERIAL_XMIT_SIZE and
async_icount are both internal serial structures that should *not* be
exposed outside of the serial driver; they're not part of the exported
interface.

--- v2.3.24/linux/include/linux/serial.h Tue Aug 31 17:29:14 1999
+++ linux/include/linux/serial.h Thu Oct 28 10:45:51 1999
@@ -37,6 +37,20 @@
#define ASYNC_CLOSING_WAIT_NONE 65535

/*
+ * The size of the serial xmit buffer is 1 page, or 4096 bytes
+ */
+#define SERIAL_XMIT_SIZE 4096
+
+/*
+ * Counters of the input lines (CTS, DSR, RI, CD) interrupts
+ */
+struct async_icount {
+ __u32 cts, dsr, rng, dcd, tx, rx;
+ __u32 frame, parity, overrun, brk;
+ __u32 buf_overrun;
+};
+
+/*
* These are the supported serial types.
*/
#define PORT_UNKNOWN 0
There seem to be other users of these definitions, notably code that was
stolen from serial.c and worked into other drivers; but they should
include serialP.h instead of moving this into serial.h.

- Ted

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:54    [W:0.098 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site