lkml.org 
[lkml]   [1999]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Bogus serialP.h patch?
Date
From
> Umm, the following patch in 2.3.25 is bogus.  SERIAL_XMIT_SIZE and
> async_icount are both internal serial structures that should *not* be
> exposed outside of the serial driver; they're not part of the exported
> interface.

They are not internal structures to your serial driver. They are internal
structures to a pile of serial drivers.

> stolen from serial.c and worked into other drivers; but they should
> include serialP.h instead of moving this into serial.h.

Then the drivers pick up all the other junk too. If you want to split
serial.h 3 ways according to whether an item is private to your driver,
private to the kernel serial drivers or public to the whole kernel sure.




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:54    [W:0.054 / U:1.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site