Messages in this thread | | | Subject | Re: Bogus serialP.h patch? | Date | Wed, 3 Nov 1999 12:15:16 +0000 (GMT) | From | Alan Cox <> |
| |
> Umm, the following patch in 2.3.25 is bogus. SERIAL_XMIT_SIZE and > async_icount are both internal serial structures that should *not* be > exposed outside of the serial driver; they're not part of the exported > interface.
They are not internal structures to your serial driver. They are internal structures to a pile of serial drivers.
> stolen from serial.c and worked into other drivers; but they should > include serialP.h instead of moving this into serial.h.
Then the drivers pick up all the other junk too. If you want to split serial.h 3 ways according to whether an item is private to your driver, private to the kernel serial drivers or public to the whole kernel sure.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |