lkml.org 
[lkml]   [2024]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 12/13] regulator: add pm8008 pmic regulator driver
Wed, May 08, 2024 at 10:37:50PM +0000, Stephen Boyd kirjoitti:
> Quoting Johan Hovold (2024-05-06 08:08:29)

..

> > + BUILD_BUG_ON((ARRAY_SIZE(pldo_ranges) != 1) ||
>
> This should be an && not || right?

> > + (ARRAY_SIZE(nldo_ranges) != 1));

In any case BUILD_BUG_ON() is not encouraged for such cases, it would be much
better to have a static_assert() near to one of those arrays.

--
With Best Regards,
Andy Shevchenko



\
 
 \ /
  Last update: 2024-05-09 14:07    [W:0.318 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site