lkml.org 
[lkml]   [2024]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 12/13] regulator: add pm8008 pmic regulator driver
    From


    On 5/6/24 17:08, Johan Hovold wrote:
    > From: Satya Priya <quic_c_skakit@quicinc.com>
    >
    > Qualcomm Technologies, Inc. PM8008 is an I2C-controlled PMIC containing
    > seven LDO regulators. Add a PM8008 regulator driver to support PMIC
    > regulator management via the regulator framework.
    >
    > Note that this driver, originally submitted by Satya Priya [1], has been
    > reworked to match the new devicetree binding which no longer describes
    > each regulator as a separate device.
    >
    > This avoids describing internal details like register offsets in the
    > devicetree and allows for extending the implementation with features
    > like over-current protection without having to update the binding.
    >
    > Specifically note that the regulator interrupts are shared between all
    > regulators.
    >
    > Note that the secondary regmap is looked up by name and that if the
    > driver ever needs to be generalised to support regulators provided by
    > the primary regmap (I2C address) such information could be added to a
    > driver lookup table matching on the parent compatible.
    >
    > This also fixes the original implementation, which looked up regulators
    > by 'regulator-name' property rather than devicetree node name and which
    > prevented the regulators from being named to match board schematics.
    >
    > [1] https://lore.kernel.org/r/1655200111-18357-8-git-send-email-quic_c_skakit@quicinc.com
    >
    > Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
    > Cc: Stephen Boyd <swboyd@chromium.org>
    > [ johan: rework probe to match new binding, amend commit message and
    > Kconfig entry]
    > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
    > ---

    I'm a bit lukewarm on calling this qcom-pm8008-regulator.. But then
    qcom-i2c-regulator or qpnp-i2c-regulator may bite due to being overly
    generic.. Would you know whether this code will also be used for e.g.
    PM8010?

    Konrad

    \
     
     \ /
      Last update: 2024-05-27 18:19    [W:8.925 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site