lkml.org 
[lkml]   [2024]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 10/13] dt-bindings: mfd: pm8008: rework binding
From
On 06/05/2024 17:08, Johan Hovold wrote:
> Rework the pm8008 binding by dropping internal details like register
> offsets and interrupts and by adding the missing regulator and
> temperature alarm properties.
>
> Note that child nodes are still used for pinctrl and regulator
> configuration.
>
> Also note that the pinctrl state definition will be extended later and
> could eventually also be shared with other PMICs (e.g. by breaking out
> bits of qcom,pmic-gpio.yaml).
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> .../devicetree/bindings/mfd/qcom,pm8008.yaml | 154 ++++++++++--------
> 1 file changed, 90 insertions(+), 64 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> index e1e05921afb4..ac1bab0261b6 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> @@ -19,116 +19,142 @@ properties:
> const: qcom,pm8008
>
> reg:
> - description:
> - I2C slave address.

Please split cleanups from actual functional/content rework.

> -
> maxItems: 1
>
> interrupts:
> maxItems: 1
>
> - description: Parent interrupt.
> -
> reset-gpios:
> maxItems: 1
>
> - "#interrupt-cells":
> + vdd_l1_l2-supply: true

No underscores in property names.



Best regards,
Krzysztof


\
 
 \ /
  Last update: 2024-05-27 18:17    [W:0.437 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site