lkml.org 
[lkml]   [2024]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] net: phy: marvell: add support for MV88E6020 internal PHYs
On Wed, Apr 24, 2024 at 02:10:22PM +0200, Matthias Schiffer wrote:
> The embedded PHYs of the MV88E6020 (88E6250 family) switch are very
> basic - they do not even have an Extended Address / Page register.
> +static struct marvell_hw_stat marvell_hw_stats_88e6020[] = {

> + { "phy_receive_errors", 0, 21, 16},

So the 0 here is bogus?

This patch is quite invasive, and it is hard to say it is worth it. I
would probably not try to reuses as much code, add functions which are
specific to the 6250. Keep it KISS.

Andrew

\
 
 \ /
  Last update: 2024-04-24 14:52    [W:0.053 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site