Messages in this thread | | | From | Bui Quang Minh <> | Subject | [PATCH v2 0/6] Ensure the copied buf is NUL terminated | Date | Wed, 24 Apr 2024 21:44:17 +0700 |
| |
Hi everyone,
I found that some drivers contains an out-of-bound read pattern like this
kern_buf = memdup_user(user_buf, count); ... sscanf(kern_buf, ...);
The sscanf can be replaced by some other string-related functions. This pattern can lead to out-of-bound read of kern_buf in string-related functions.
This series fix the above issue by replacing memdup_user with memdup_user_nul.
Thanks, Quang Minh.
To: Jesse Brandeburg <jesse.brandeburg@intel.com> To: Tony Nguyen <anthony.l.nguyen@intel.com> To: David S. Miller <davem@davemloft.net> To: Eric Dumazet <edumazet@google.com> To: Jakub Kicinski <kuba@kernel.org> To: Paolo Abeni <pabeni@redhat.com> To: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> To: Rasesh Mody <rmody@marvell.com> To: Sudarsana Kalluru <skalluru@marvell.com> To: GR-Linux-NIC-Dev@marvell.com To: Anil Gurumurthy <anil.gurumurthy@qlogic.com> To: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com> To: James E.J. Bottomley <James.Bottomley@HansenPartnership.com> To: Martin K. Petersen <martin.petersen@oracle.com> To: Fabian Frederick <fabf@skynet.be> To: Saurav Kashyap <skashyap@marvell.com> To: GR-QLogic-Storage-Upstream@marvell.com To: Nilesh Javali <nilesh.javali@cavium.com> To: Arun Easi <arun.easi@cavium.com> To: Manish Rangankar <manish.rangankar@cavium.com> To: Vineeth Vijayan <vneethv@linux.ibm.com> To: Peter Oberparleiter <oberpar@linux.ibm.com> To: Heiko Carstens <hca@linux.ibm.com> To: Vasily Gorbik <gor@linux.ibm.com> To: Alexander Gordeev <agordeev@linux.ibm.com> To: Christian Borntraeger <borntraeger@linux.ibm.com> To: Sven Schnelle <svens@linux.ibm.com> To: Dupuis, Chad <chad.dupuis@cavium.com> To: Sunil Goutham <sgoutham@marvell.com> To: Linu Cherian <lcherian@marvell.com> To: Geetha sowjanya <gakula@marvell.com> To: Jerin Jacob <jerinj@marvell.com> To: hariprasad <hkelam@marvell.com> To: Subbaraya Sundeep <sbhatta@marvell.com> Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: Saurav Kashyap <saurav.kashyap@cavium.com> Cc: linux-s390@vger.kernel.org Cc: Jens Axboe <axboe@kernel.dk> Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
Changes in v2: - Patch 5: use memdup_user_nul instead - Add patch 6 - Link to v1: https://lore.kernel.org/r/20240422-fix-oob-read-v1-0-e02854c30174@gmail.com
--- Bui Quang Minh (6): ice: ensure the copied buf is NUL terminated bna: ensure the copied buf is NUL terminated bfa: ensure the copied buf is NUL terminated qedf: ensure the copied buf is NUL terminated cio: ensure the copied buf is NUL terminated octeontx2-af: avoid off-by-one read from userspace
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 4 ++-- drivers/net/ethernet/intel/ice/ice_debugfs.c | 8 ++++---- drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 +--- drivers/s390/cio/cio_inject.c | 2 +- drivers/scsi/bfa/bfad_debugfs.c | 4 ++-- drivers/scsi/qedf/qedf_debugfs.c | 2 +- 6 files changed, 11 insertions(+), 13 deletions(-) --- base-commit: ed30a4a51bb196781c8058073ea720133a65596f change-id: 20240422-fix-oob-read-19ae7f8f3711
Best regards, -- Bui Quang Minh <minhquangbui99@gmail.com>
| |