lkml.org 
[lkml]   [2024]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: vc04_services: Reformatted code according to Kernel Documents.
The subject is too vague.

On Sun, Apr 14, 2024 at 05:21:06PM +0530, sumadhura kalyan wrote:
> Issue found by checkpatch
^^^^^^^^^^^^^^^^^^^^^^^^^
What issue?

A better commit message would be:

==================
Subject: [PATCH v3] staging: vc04_services: re-align function parameters

Checkpatch complains that:

CHECK: Lines should not end with a '('
#45: FILE: drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h:45:
+typedef void (*vchiq_mmal_buffer_cb)(

Re-align the function parameters to make checkpatch happy.
================

>
> Signed-off-by: sumadhura kalyan <opensourcecond@gmail.com>
^ ^
You should make these capital letters... It's supposed to look formal
like you're signing a legal document.

regards,
dan carpenter


\
 
 \ /
  Last update: 2024-05-27 16:40    [W:0.035 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site