Messages in this thread | | | Date | Fri, 29 Mar 2024 16:04:42 +0100 | From | Kory Maincent <> | Subject | Re: [PATCH net-next v6 13/17] net: pse-pd: Use regulator framework within PSE framework |
| |
On Tue, 26 Mar 2024 15:04:50 +0100 Kory Maincent <kory.maincent@bootlin.com> wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > Integrate the regulator framework to the PSE framework for enhanced > access to features such as voltage, power measurement, and limits, which > are akin to regulators. Additionally, PSE features like port priorities > could potentially enhance the regulator framework. Note that this > integration introduces some implementation complexity, including wrapper > callbacks, but the potential benefits make it worthwhile. > > Regulator are using enable counter with specific behavior. > Two calls to regulator_disable will trigger kernel warnings. > If the counter exceeds one, regulator_disable call won't disable the > PSE PI. These behavior isn't suitable for PSE control. > Added a boolean 'enabled' state to prevent multiple calls to > regulator_enable/disable. These calls will only be called from PSE > framework as it won't have any regulator children, therefore no mutex are > needed to safeguards this boolean. > > regulator_get needs the consumer device pointer. Use PSE as regulator > provider and consumer device until we have RJ45 ports represented in > the Kernel.
Oleksij, could you verify this patch does not break pse_regulator driver?
Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
| |