Messages in this thread Patch in this message | | | From | alexs@kernel ... | Subject | [PATCH v3] x86/dumpstack: uniform die messages prompt | Date | Wed, 27 Mar 2024 10:44:19 +0800 |
| |
From: Alex Shi <alexs@kernel.org>
panic() has a uniform prompt, like "Kernel panic - not syncing:". That's easy to indicate a panic there. But die() message doesn't have.
We died thousands machine with very different reasons weekly. w/o a prompt in dmesg, it's hard to write scripts to collect and anaylis the die reasons. That makes admins' life pretty hard.
A uniform die() prompt like "Oops:" could save some hair for admins.
Signed-off-by: Alex Shi <alexs@kernel.org> To: linux-kernel@vger.kernel.org To: "H. Peter Anvin" <hpa@zytor.com> To: x86@kernel.org To: Dave Hansen <dave.hansen@linux.intel.com> To: Borislav Petkov <bp@alien8.de> To: Ingo Molnar <mingo@redhat.com> To: Thomas Gleixner <tglx@linutronix.de> To: Peter Zijlstra <peterz@infradead.org> To: Josh Poimboeuf <jpoimboe@kernel.org> --- arch/x86/kernel/dumpstack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index f18ca44c904b..e1358ef80b59 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -405,8 +405,8 @@ static void __die_header(const char *str, struct pt_regs *regs, long err) pr = IS_ENABLED(CONFIG_PREEMPT_RT) ? " PREEMPT_RT" : " PREEMPT"; printk(KERN_DEFAULT - "%s: %04lx [#%d]%s%s%s%s%s\n", str, err & 0xffff, ++die_counter, - pr, + "Oops: %s: %04lx [#%d]%s%s%s%s%s\n", str, err & 0xffff, + ++die_counter, pr, IS_ENABLED(CONFIG_SMP) ? " SMP" : "", debug_pagealloc_enabled() ? " DEBUG_PAGEALLOC" : "", IS_ENABLED(CONFIG_KASAN) ? " KASAN" : "", -- 2.43.0
| |