Messages in this thread | | | From | Karthik Sundaravel <> | Subject | | Date | Thu, 21 Mar 2024 13:46:24 +0530 |
| |
Dear Maintainers, Thanks for the review and suggestions for my patch. In this patch v6, I have used container_of() instead of ice_get_vf_by_id(). Also since the ice_set_vf_fn_mac() is a copy of the existing function ice_set_vf_mac(), except for the parameters, I didn't absorb the review comments on that. Please advise if the validation checks needs to be modified.
v5 -> v6 -------- - Changed data type of vf_id to u16 - Used container_of(port, struct ice_vf, devlink_port) to get the vf instead of ice_get_vf_by_id()/ice_put_vf()
v4 -> v5 -------- - Cloned ice_set_vf_mac() to ice_set_vf_fn_mac() so that the parameter ice_pf is used instead of net_device of vf - removed redundant error handling
v3 -> v4 -------- - Released the vf device by calling ice_put_vf()
v2 -> v3 -------- - Fill the extack message instead of dev_err()
v1 -> v2 -------- - called ice_set_vf_mac() directly from the devlink port function handlers.
RFC -> v1 --------- - Add the function handlers to set and get the HW address for the VF representor ports.
| |