Messages in this thread | | | From | Peter Griffin <> | Date | Mon, 5 Feb 2024 15:25:14 +0000 | Subject | Re: [PATCH v4 02/16] spi: s3c64xx: explicitly include <linux/bits.h> |
| |
On Mon, 5 Feb 2024 at 12:45, Tudor Ambarus <tudor.ambarus@linaro.org> wrote: > > The driver uses GENMASK() but does not include <linux/bits.h>. > > It is good practice to directly include all headers used, it avoids > implicit dependencies and spurious breakage if someone rearranges > headers and causes the implicit include to vanish. > > Include the missing header. > > Fixes: 1224e29572f6 ("spi: s3c64xx: Fix large transfers with DMA") > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > ---
Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
| |