Messages in this thread | | | Date | Mon, 5 Feb 2024 14:32:46 +0100 | From | Miquel Raynal <> | Subject | Re: [PATCH v4 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property |
| |
Hi William,
william.zhang@broadcom.com wrote on Fri, 2 Feb 2024 16:28:23 -0800:
> Add brcm,wp-not-connected property to have an option for disabling this > feature on broadband board design that does not connect WP pin. > > Signed-off-by: William Zhang <william.zhang@broadcom.com> > > --- > > Changes in v4: > - Move the WP pin property to this separate patch and change it to > boolean type. > > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml > index e54ca08a798a..d0168d55c73e 100644 > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml > @@ -113,6 +113,14 @@ properties: > earlier versions of this core that include WP > type: boolean > > + brcm,wp-not-connected: > + description: > + Use this property when board design does not connect controller's > + NAND_WPb pin to NAND chip's WP_L pin and disable the write > + protection feature. By default, controller assumes the pin is > + connected and feature is used.
I would rephrase slightly. What about:
WP pin is not physically wired to the NAND chip. Write protection feature cannot be used.
> + $ref: /schemas/types.yaml#/definitions/flag > + > patternProperties: > "^nand@[a-f0-9]$": > type: object
Thanks, Miquèl
| |