Messages in this thread | | | Date | Sun, 4 Feb 2024 13:56:59 -0800 | Subject | Re: [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property | From | William Zhang <> |
| |
On 2/3/24 06:49, Conor Dooley wrote: > On Fri, Feb 02, 2024 at 04:28:24PM -0800, William Zhang wrote: >> Add brcm,nand-ecc-use-strap to get ecc and spare area size settings from >> board boot strap for broadband board designs because they do not specify >> ecc setting in dts but rather using the strap setting. >> >> Signed-off-by: William Zhang <william.zhang@broadcom.com> >> >> --- >> >> Changes in v4: >> - Move ecc strap property to this separate patch and remove some >> non-binding related text from the description >> >> Changes in v3: None >> Changes in v2: None >> >> Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml >> index d0168d55c73e..2599d902ec3a 100644 >> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml >> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml >> @@ -147,6 +147,14 @@ patternProperties: >> layout. >> $ref: /schemas/types.yaml#/definitions/uint32 >> >> + brcm,nand-ecc-use-strap: >> + description: >> + This flag indicates the ecc strength and spare area size should >> + be retrieved from the SoC NAND boot strap setting instead of >> + nand-ecc-strength and brcm,nand-oob-sector-size or auto detection. > > I'm still on the fence about this being overly prescriptive about the > operating systems behaviour. I think it would be good to say why the > strap values are better than those explicitly provided in DT rather than > just saying "these strap values should be used". > This is a board/SoC design choice. I wouldn't advise it as better choice as other board/SoC may not have that option. But definitively for BCMBCA SoC board design, it is better and much easier and convenient option than explicit dt setting. How about: This property provides a choice for retrieving ecc strength and spare area size from the SoC NAND boot strap setting. It is commonly used by the BCMBCA SoC board design.
>> + This is commonly used by the BCMBCA SoC board design. >> + $ref: /schemas/types.yaml#/definitions/flag >> + >> unevaluatedProperties: false >> >> allOf: >> -- >> 2.37.3 >> [unhandled content-type:application/pkcs7-signature]
| |