Messages in this thread | | | Date | Mon, 5 Feb 2024 11:13:49 +0000 | From | Jonathan Cameron <> | Subject | Re: [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig |
| |
On Sun, 4 Feb 2024 18:46:13 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
> Commit 5d7107c72796 ("perf: CXL Performance Monitoring Unit driver") > added the config entries for CXL_PMU in drivers/cxl/Kconfig and > drivers/perf/Kconfig, so it can be toggled from multiple locations: > > [1] Device Drivers > -> PCI support > -> CXL (Compute Expres Link) Devices > -> CXL Performance Monitoring Unit > > [2] Device Drivers > -> Performance monitor support > -> CXL Performance Monitoring Unit > > This complicates things, and nobody else does this. > > I kept the one in drivers/perf/Kconfig because CONFIG_CXL_PMU controls > the compilation of drivers/perf/cxl_pmu.c. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
oops.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Thanks
Jonathan
> --- > > drivers/cxl/Kconfig | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig > index 67998dbd1d46..5f3c9c5529b9 100644 > --- a/drivers/cxl/Kconfig > +++ b/drivers/cxl/Kconfig > @@ -144,17 +144,4 @@ config CXL_REGION_INVALIDATION_TEST > If unsure, or if this kernel is meant for production environments, > say N. > > -config CXL_PMU > - tristate "CXL Performance Monitoring Unit" > - default CXL_BUS > - depends on PERF_EVENTS > - help > - Support performance monitoring as defined in CXL rev 3.0 > - section 13.2: Performance Monitoring. CXL components may have > - one or more CXL Performance Monitoring Units (CPMUs). > - > - Say 'y/m' to enable a driver that will attach to performance > - monitoring units and provide standard perf based interfaces. > - > - If unsure say 'm'. > endif
| |