Messages in this thread | | | Date | Mon, 5 Feb 2024 00:57:41 +0300 | From | Serge Semin <> | Subject | Re: [PATCH net] net: stmmac: xgmac: fix a typo of register name in DPP safety handling |
| |
On Sat, Feb 03, 2024 at 01:31:33PM +0800, Furong Xu wrote: > DDPP is copied from Synopsys Data book: > > DDPP: Disable Data path Parity Protection. > When it is 0x0, Data path Parity Protection is enabled. > When it is 0x1, Data path Parity Protection is disabled. > > The macro name should be XGMAC_DPP_DISABLE.
Thanks!
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Serge(y)
> > Fixes: 46eba193d04f ("net: stmmac: xgmac: fix handling of DPP safety error for DMA channels") > Signed-off-by: Furong Xu <0x1207@gmail.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > index 5c67a3f89f08..6a2c7d22df1e 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > @@ -304,7 +304,7 @@ > #define XGMAC_TXCEIE BIT(0) > #define XGMAC_MTL_ECC_INT_STATUS 0x000010cc > #define XGMAC_MTL_DPP_CONTROL 0x000010e0 > -#define XGMAC_DDPP_DISABLE BIT(0) > +#define XGMAC_DPP_DISABLE BIT(0) > #define XGMAC_MTL_TXQ_OPMODE(x) (0x00001100 + (0x80 * (x))) > #define XGMAC_TQS GENMASK(25, 16) > #define XGMAC_TQS_SHIFT 16 > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > index 04d7c4dc2e35..323c57f03c93 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > @@ -928,7 +928,7 @@ dwxgmac3_safety_feat_config(void __iomem *ioaddr, unsigned int asp, > /* 5. Enable Data Path Parity Protection */ > value = readl(ioaddr + XGMAC_MTL_DPP_CONTROL); > /* already enabled by default, explicit enable it again */ > - value &= ~XGMAC_DDPP_DISABLE; > + value &= ~XGMAC_DPP_DISABLE; > writel(value, ioaddr + XGMAC_MTL_DPP_CONTROL); > > return 0; > -- > 2.34.1 >
| |