Messages in this thread Patch in this message | | | From | Armin Wolf <> | Subject | [PATCH v2 1/2] platform/x86/amd/pmf: Do not use readl() for policy buffer access | Date | Tue, 27 Feb 2024 15:54:59 +0100 |
| |
The policy buffer is allocated using normal memory allocation functions, so readl() should not be used on it.
Compile-tested only.
Signed-off-by: Armin Wolf <W_Armin@gmx.de> --- Changes since v1: - get the full dword instead of only 8 bits --- drivers/platform/x86/amd/pmf/tee-if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c index 16973bebf55f..b3491268b6a0 100644 --- a/drivers/platform/x86/amd/pmf/tee-if.c +++ b/drivers/platform/x86/amd/pmf/tee-if.c @@ -249,8 +249,8 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev) u32 cookie, length; int res;
- cookie = readl(dev->policy_buf + POLICY_COOKIE_OFFSET); - length = readl(dev->policy_buf + POLICY_COOKIE_LEN); + cookie = *(u32 *)(dev->policy_buf + POLICY_COOKIE_OFFSET); + length = *(u32 *)(dev->policy_buf + POLICY_COOKIE_LEN);
if (cookie != POLICY_SIGN_COOKIE || !length) return -EINVAL; -- 2.39.2
| |