Messages in this thread | | | From | Daniel Baluta <> | Date | Tue, 27 Feb 2024 14:54:23 +0200 | Subject | Re: [PATCH] Convert the Imagination Technologies SPDIF Input Controllerto DT schema. |
| |
Few comments:
Subject should contain a prefix e.g:
ASoC: dt-bindings: img,spdif-in: Convert Imagination ....
Also do not add a '.' at the end of the subject line.
one more comment inline:
> + > +examples: > + - | > + #include <dt-bindings/clock/pistachio-clk.h> > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/interrupt-controller/mips-gic.h> > + #include <dt-bindings/reset/pistachio-resets.h> > + spdif_in: spdif-in@18100e00 {
Node name should be generic:
e.g spdif_in: spdif@18100....
| |