lkml.org 
[lkml]   [2024]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Convert the Imagination Technologies SPDIF Input Controllerto DT schema.
Few comments:

Subject should contain a prefix e.g:

ASoC: dt-bindings: img,spdif-in: Convert Imagination ....

Also do not add a '.' at the end of the subject line.

one more comment inline:

> +
> +examples:
> + - |
> + #include <dt-bindings/clock/pistachio-clk.h>
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/interrupt-controller/mips-gic.h>
> + #include <dt-bindings/reset/pistachio-resets.h>
> + spdif_in: spdif-in@18100e00 {

Node name should be generic:

e.g spdif_in: spdif@18100....

\
 
 \ /
  Last update: 2024-05-27 15:24    [W:0.214 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site