Messages in this thread | | | From | Daniel Baluta <> | Date | Tue, 27 Feb 2024 18:27:55 +0200 | Subject | Re: [PATCH v2] ASoC: dt-bindings: img,spdif-in: Convert to dtschema |
| |
This looks much better than v1. Make sure you have addressed all comments from the previous version and add a short log under the scissor line explaining what you have changed.
Few comments inline:
On Tue, Feb 27, 2024 at 6:13 PM Javier García <javier.garcia.ta@udima.es> wrote: > > Convert the Imagination Technologies SPDIF Input Controllerto DT schema. > > Signed-off-by: Javier García <javier.garcia.ta@udima.es> > --- ^ this is the scissor line. Here you add the change log.
Changes since v1: - re-written the subject inline to include relevant prefix - removed header file as it is not used - ....etc
> +$id: http://devicetree.org/schemas/sound/img,spdif-in.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Imagination Technologies SPDIF Input Controller > + > +maintainers: > + - Liam Girdwood <lgirdwood@gmail.com> > + - Mark Brown <broonie@kernel.org>
Please do not blindly add people here. The most proper candidate for this is the people who wrote the original file.
Using git log we can find Damien.Horsley <Damien.Horsley@imgtec.com>
Damien,
Is it OK to add you as a maintainer for this file as you wrote the original driver?
Other than this looks good to me as far as i can tell.
thanks, Daniel.
| |