Messages in this thread | | | Date | Tue, 27 Feb 2024 18:38:03 +0000 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH 2/2] usb: misc: onboard_usb_hub: Add support for TI TUSB8020B |
| |
On Tue, Feb 27, 2024 at 05:02:28PM +0800, Macpaul Lin wrote: > The TI TUSB8020B is a 2-port USB 3.0 hub. Add support for > this hub in the driver in order to bring up reset, and supply > dependencies. > > Power-up: Issue a GPIO reset (GRSTz) 3ms after VDD and VDD33 stabilize. > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Generally this looks good to me, but it should probably wait for "usb: misc: onboard_dev: use device supply names" [1] to land and use a device specific supply name instead of 'vdd'.
[1] https://lore.kernel.org/linux-usb/20240220-onboard_xvf3500-v4-6-dc1617cc5dd4@wolfvision.net/
| |