Messages in this thread Patch in this message | | | From | Thorsten Blum <> | Subject | [PATCH] time: Use div64_long() instead of do_div() | Date | Mon, 26 Feb 2024 00:25:42 +0100 |
| |
Fixes Coccinelle/coccicheck warning reported by do_div.cocci.
Compared to do_div(), div64_long() does not implicitly cast the divisor and does not unnecessarily calculate the remainder.
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com> --- kernel/time/jiffies.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c index bc4db9e5ab70..9d23178e2b6a 100644 --- a/kernel/time/jiffies.c +++ b/kernel/time/jiffies.c @@ -91,7 +91,7 @@ int register_refined_jiffies(long cycles_per_second) /* shift_hz stores hz<<8 for extra accuracy */ shift_hz = (u64)cycles_per_second << 8; shift_hz += cycles_per_tick/2; - do_div(shift_hz, cycles_per_tick); + shift_hz = div64_long(shift_hz, cycles_per_tick); /* Calculate nsec_per_tick using shift_hz */ nsec_per_tick = (u64)NSEC_PER_SEC << 8; nsec_per_tick += (u32)shift_hz/2; -- 2.43.2
| |