Messages in this thread | | | Date | Sat, 24 Feb 2024 03:02:20 +0000 (GMT) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH 6/6] sparc32: Fix parport build with sparc32 |
| |
On Fri, 23 Feb 2024, Sam Ravnborg via B4 Relay wrote:
> include/asm/parport.h is sparc64 specific. > Rename it to parport_64.h and use the generic version for sparc32. > > This fixed all{mod,yes}config build errors like: > > parport_pc.c:(.text):undefined-reference-to-ebus_dma_enable > parport_pc.c:(.text):undefined-reference-to-ebus_dma_irq_enable > parport_pc.c:(.text):undefined-reference-to-ebus_dma_register > > The errors occur as the sparc32 build references sparc64 symbols. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Andreas Larsson <andreas@gaisler.com> > Cc: Randy Dunlap <rdunlap@infradead.org> > Cc: Maciej W. Rozycki <macro@orcam.me.uk> > Closes: https://lore.kernel.org/r/20230406160548.25721-1-rdunlap@infradead.org/ > Fixes: 66bcd06099bb ("parport_pc: Also enable driver for PCI systems") > Cc: stable@vger.kernel.org # v5.18+ > ---
LGTM, it relies on SPARC never to enable ISA.
Reviewed-by: Maciej W. Rozycki <macro@orcam.me.uk> Tested-by: Maciej W. Rozycki <macro@orcam.me.uk> # build-tested
The other changes in this patch series address issues that do not appear with my ad-hoc SPARC test configuration, so I have no immediate way to verify them.
Maciej
| |