lkml.org 
[lkml]   [2024]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] sparc32: Do not select GENERIC_ISA_DMA
On Fri, 23 Feb 2024, Sam Ravnborg via B4 Relay wrote:

> sparc32 do not support generic isa dma, so do not select the symbol.
> Without this fix, the following patch would break the build with a
> missing prototype.

Not according to my observations, kernel/dma.c is always built for
GENERIC_ISA_DMA configurations, so:

kernel/dma.c:70:5: error: no previous prototype for 'request_dma' [-Werror=missing-prototypes]
70 | int request_dma(unsigned int dmanr, const char * device_id)
| ^~~~~~~~~~~
kernel/dma.c:88:6: error: no previous prototype for 'free_dma' [-Werror=missing-prototypes]
88 | void free_dma(unsigned int dmanr)
| ^~~~~~~~

are issued regardless (and FAOD with PARPORT_PC unset).

I can't speak for SPARC support for ISA DMA, but it seems to me like the
second sentence would best be removed, as would the Fixes: tag (in favour
to:

Fixes: 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally")

I presume), and possibly the messages quoted above included instead.

Maciej

\
 
 \ /
  Last update: 2024-05-27 15:20    [W:0.112 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site