| Date | Sat, 24 Feb 2024 09:30:14 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH 03/13] dt-bindings: hwmon: lm75: add label property |
| |
On Thu, Feb 15, 2024 at 05:52:10PM +0100, Théo Lebrun wrote: > Declare optional label devicetree property. Show usage in one example > with dummy name. > > To: Jean Delvare <jdelvare@suse.com> > To: Guenter Roeck <linux@roeck-us.net> > Cc: <linux-hwmon@vger.kernel.org> > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
What is the verdict here ? Should I apply it and accept another patch to update it, or should it be reworked to be based on the new common hwmon schema ?
Thanks, Guenter
> --- > Documentation/devicetree/bindings/hwmon/lm75.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/lm75.yaml b/Documentation/devicetree/bindings/hwmon/lm75.yaml > index ed269e428a3d..5ca2c83b413d 100644 > --- a/Documentation/devicetree/bindings/hwmon/lm75.yaml > +++ b/Documentation/devicetree/bindings/hwmon/lm75.yaml > @@ -52,6 +52,9 @@ properties: > interrupts: > maxItems: 1 > > + label: > + description: user-facing name of the hardware monitor > + > required: > - compatible > - reg > @@ -83,6 +86,7 @@ examples: > compatible = "st,stlm75"; > reg = <0x48>; > vs-supply = <&vs>; > + label = "CPU temp"; > }; > }; > - |
|