Messages in this thread Patch in this message | | | From | Alfredo Cruz <> | Subject | [PATCH] ARM: sa1111: fix put_device() before device_add() in error path | Date | Wed, 21 Feb 2024 22:38:37 +0100 |
| |
When request_resource() fails, a jump is made to err_resource label which calls put_device() on &dev->res without adding it first. Kept the err_resource label and moved put_device() to err_add label.
Signed-off-by: Alfredo Cruz <alfredo.carlon@gmail.com> --- arch/arm/common/sa1111.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c index 1fbd7363cf11..76bf15da5115 100644 --- a/arch/arm/common/sa1111.c +++ b/arch/arm/common/sa1111.c @@ -779,8 +779,8 @@ sa1111_init_one_child(struct sa1111 *sachip, struct resource *parent, err_add: release_resource(&dev->res); - err_resource: put_device(&dev->dev); + err_resource: err_alloc: return ret; } -- 2.43.2
| |