Messages in this thread | | | Date | Fri, 2 Feb 2024 08:57:02 +0100 | Subject | Re: fpga: dfl: fme: Return directly after a failed devm_kasprintf() call in fme_perf_pmu_register() | From | Markus Elfring <> |
| |
>> Thus return directly after a failed devm_kasprintf() call. >> >> Fixes: 724142f8c42a7 ("fpga: dfl: fme: add performance reporting support") > > This basically doesn't affect runtime because perf_pmu_register() checks for NULL
https://elixir.bootlin.com/linux/v6.8-rc2/source/kernel/events/core.c#L11527
Do you prefer the usage of the error code “-ENOMEM” instead of “-EINVAL” as an indication for a failed memory allocation?
> so no need for a Fixes tag.
Does the selection of a more appropriate error code qualify for this tag?
Regards, Markus
| |