Messages in this thread | | | Date | Wed, 31 Jan 2024 08:43:37 +0300 | From | Dan Carpenter <> | Subject | Re: fpga: dfl: fme: Return directly after a failed devm_kasprintf() call in fme_perf_pmu_register() |
| |
On Tue, Jan 30, 2024 at 06:09:14PM +0100, Markus Elfring wrote: > >> Thus return directly after a failed devm_kasprintf() call. > >> > >> Fixes: 724142f8c42a7 ("fpga: dfl: fme: add performance reporting support") > > > > This basically doesn't affect runtime because perf_pmu_register() checks > > for NULL so no need for a Fixes tag. > > I suggest to clarify this view a bit more also according to statements > like the following. > > 1. https://elixir.bootlin.com/linux/v6.8-rc2/source/kernel/events/core.c#L11532 > perf_pmu_register: > … > pmu->name = name; > …
The check is right before that on line 11527.
https://elixir.bootlin.com/linux/v6.8-rc2/source/kernel/events/core.c#L11527
regards, dan carpenter
| |