Messages in this thread Patch in this message | | | From | 陈骏 <> | Subject | [PATCH v2] irqchip/mbigen: Fix incorrect null pointer check | Date | Mon, 19 Feb 2024 16:53:14 +0800 |
| |
From: Chen Jun <chenjun102@huawei.com>
bus_get_dev_root returns sp->dev_root set in subsys_register. And subsys_register is not called by platform_bus_init.
For platform_bus_type, bus_get_dev_root always returns NULL. This makes mbigen_of_create_domain always return -ENODEV.
Fixes: fea087fc291b ("irqchip/mbigen: move to use bus_get_dev_root()") Signed-off-by: Chen Jun <chenjun102@huawei.com> --- v2: Modify change log v1: https://lore.kernel.org/all/20240129130003.18181-1-chenjun102@huawei.com/
drivers/irqchip/irq-mbigen.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c index 5101a3fb11df..58881d313979 100644 --- a/drivers/irqchip/irq-mbigen.c +++ b/drivers/irqchip/irq-mbigen.c @@ -235,22 +235,17 @@ static const struct irq_domain_ops mbigen_domain_ops = { static int mbigen_of_create_domain(struct platform_device *pdev, struct mbigen_device *mgn_chip) { - struct device *parent; struct platform_device *child; struct irq_domain *domain; struct device_node *np; u32 num_pins; int ret = 0; - parent = bus_get_dev_root(&platform_bus_type); - if (!parent) - return -ENODEV; - for_each_child_of_node(pdev->dev.of_node, np) { if (!of_property_read_bool(np, "interrupt-controller")) continue; - child = of_platform_device_create(np, NULL, parent); + child = of_platform_device_create(np, NULL, NULL); if (!child) { ret = -ENOMEM; break; @@ -273,7 +268,6 @@ static int mbigen_of_create_domain(struct platform_device *pdev, } } - put_device(parent); if (ret) of_node_put(np); -- 2.17.1
| |