lkml.org 
[lkml]   [2024]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 14/18] PCI/pwrctl: add a power control driver for WCN7850
On Fri, Feb 16, 2024 at 09:32:11PM +0100, Bartosz Golaszewski wrote:

> +static struct pci_pwrctl_wcn7850_vreg pci_pwrctl_wcn7850_vregs[] = {
> + {
> + .name = "vdd",
> + .load_uA = 16000,
> + },

I know a bunch of the QC stuff includes these load numbers but are they
actually doing anything constructive? It keeps coming up that they're
causing a bunch of work and it's not clear that they have any great
effect on modern systems.

> +static int pci_pwrctl_wcn7850_power_on(struct pci_pwrctl_wcn7850_ctx *ctx)
> +{
> + int ret;
> +
> + ret = regulator_bulk_enable(ctx->pdata->num_vregs, ctx->regs);
> + if (ret)
> + return ret;
> +
> + ret = clk_prepare_enable(ctx->clk);
> + if (ret)
> + return ret;

This won't disable the regulators on error.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2024-05-27 15:10    [W:1.549 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site