Messages in this thread | | | Date | Mon, 19 Feb 2024 08:32:07 +0100 | Subject | Re: [PATCH v5 03/18] dt-bindings: regulator: describe the PMU module of the QCA6390 package | From | Krzysztof Kozlowski <> |
| |
On 17/02/2024 19:32, Bartosz Golaszewski wrote: > On Sat, Feb 17, 2024 at 4:48 PM Mark Brown <broonie@kernel.org> wrote: >> >> On Fri, Feb 16, 2024 at 09:32:00PM +0100, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> >>> The QCA6390 package contains discreet modules for WLAN and Bluetooth. They >>> are powered by the Power Management Unit (PMU) that takes inputs from the >>> host and provides LDO outputs. This document describes this module. >> >> Please submit patches using subject lines reflecting the style for the >> subsystem, this makes it easier for people to identify relevant patches. >> Look at what existing commits in the area you're changing are doing and >> make sure your subject lines visually resemble what they're doing. >> There's no need to resubmit to fix this alone. > > Mark, > > This is quite vague, could you elaborate? I have no idea what is wrong > with this patch.
Use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.
Best regards, Krzysztof
| |