lkml.org 
[lkml]   [2024]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] nfsd: fix memory leak in __cld_pipe_inprogress_downcall()
Date
Dynamic memory, referenced by 'princhash.data' and 'name.data', 
is allocated by calling function 'memdup_user' and lost
at __cld_pipe_inprogress_downcall() function return

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 11a60d159259 ("nfsd: add a "GetVersion" upcall for nfsdcld")
Signed-off-by: Aleksandr Burakov <a.burakov@rosalinux.ru>
---
fs/nfsd/nfs4recover.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
index 2c060e0b1604..02663484782d 100644
--- a/fs/nfsd/nfs4recover.c
+++ b/fs/nfsd/nfs4recover.c
@@ -850,6 +850,8 @@ __cld_pipe_inprogress_downcall(const struct cld_msg_v2 __user *cmsg,
kfree(princhash.data);
return -EFAULT;
}
+ kfree(name.data);
+ kfree(princhash.data);
return nn->client_tracking_ops->msglen;
}
return -EFAULT;
--
2.25.1

\
 
 \ /
  Last update: 2024-05-27 15:06    [W:0.226 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site