Messages in this thread Patch in this message | | | From | Mark O'Donovan <> | Subject | [PATCH] net: stmmac: xgmac: fix initializer element is not constant error | Date | Mon, 12 Feb 2024 15:43:19 +0000 |
| |
GCC prior to 8.x gives an "initializer element is not constant" error for the uses of dpp_tx_err in dwxgmac3_dma_dpp_errors. Newer compilers accept either version.
More info here: https://lore.kernel.org/all/20240103-fix-bq24190_charger-vbus_desc-non-const-v1-1-115ddf798c70@kernel.org
Signed-off-by: Mark O'Donovan <shiftee@posteo.net> --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c index 323c57f03c93..c02c035b81c0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c @@ -830,8 +830,8 @@ static const struct dwxgmac3_error_desc dwxgmac3_dma_errors[32]= { { false, "UNKNOWN", "Unknown Error" }, /* 31 */ }; -static const char * const dpp_rx_err = "Read Rx Descriptor Parity checker Error"; -static const char * const dpp_tx_err = "Read Tx Descriptor Parity checker Error"; +#define dpp_rx_err "Read Rx Descriptor Parity checker Error" +#define dpp_tx_err "Read Tx Descriptor Parity checker Error" static const struct dwxgmac3_error_desc dwxgmac3_dma_dpp_errors[32] = { { true, "TDPES0", dpp_tx_err }, { true, "TDPES1", dpp_tx_err }, base-commit: 841c35169323cd833294798e58b9bf63fa4fa1de -- 2.39.2
| |