Messages in this thread | | | Date | Sun, 11 Feb 2024 21:45:04 +0100 | Subject | Re: [PATCH v1 04/10] phy: rockchip: add usbdp combo phy driver | From | Johan Jonker <> |
| |
On 2/9/24 19:17, Sebastian Reichel wrote: > This adds a new USBDP combo PHY with Samsung IP block driver. > > The driver get lane mux and mapping info in 2 ways, supporting > DisplayPort alternate mode or parsing from DT. When parsing from DT, > the property "rockchip,dp-lane-mux" provide the DP mux and mapping > info. This is needed when the PHY is not used with TypeC Alt-Mode. > For example if the USB3 interface of the PHY is connected to a USB > Type A connector and the DP interface is connected to a DisplayPort > connector. > > When do DP link training, need to set lane number, link rate, swing, > and pre-emphasis via PHY configure interface. > > Co-developed-by: Heiko Stuebner <heiko@sntech.de> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > Co-developed-by: Zhang Yubing <yubing.zhang@rock-chips.com> > Signed-off-by: Zhang Yubing <yubing.zhang@rock-chips.com> > Co-developed-by: Frank Wang <frank.wang@rock-chips.com> > Signed-off-by: Frank Wang <frank.wang@rock-chips.com> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > ---
For Linux FTRACE filters it is needed that all functions in a driver start with the same function prefix. Currently there's a mix of udphy_* and rockchip_* Maybe use rk_udphy_* ??? similar to for example rk_nfc_* in rockchip-nand-controller.c
Johan
| |