Messages in this thread | | | Date | Mon, 12 Feb 2024 19:48:37 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCH v1 06/10] arm64: dts: rockchip: add USBDP phys on rk3588 |
| |
Hi Johan,
On Sun, Feb 11, 2024 at 08:24:36PM +0100, Johan Jonker wrote: > > + u2phy1: usb2-phy@4000 { > > "usb2phy@[0-9a-f]+$":
Interesting. I would have expected that to pop up in dtbs_check, but it does not for some reason. I will fix it for all usb2phy instances in rk3588.
> > + compatible = "rockchip,rk3588-usb2phy"; > > + reg = <0x4000 0x10>; > > + interrupts = <GIC_SPI 394 IRQ_TYPE_LEVEL_HIGH 0>; > > > + resets = <&cru SRST_OTGPHY_U3_1>, <&cru SRST_P_USB2PHY_U3_1_GRF0>; > > + reset-names = "phy", "apb"; > > + clocks = <&cru CLK_USB2PHY_HDPTXRXPHY_REF>; > > + clock-names = "phyclk"; > > + clock-output-names = "usb480m_phy1"; > > + #clock-cells = <0>; > > Align with the (new) documentation > about property ordering. > > > + status = "disabled"; > > + > > + u2phy1_otg: otg-port { > > + #phy-cells = <0>; > > + status = "disabled"; > > + }; > > + }; > > + };
The above follows everything from [0], which does not specify an order for the "standard/common properties". For those this follows the order of existing usb2phy nodes. Did I miss any other new Documentation?
[0] https://www.kernel.org/doc/html/next/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
-- Sebastian
| |