Messages in this thread Patch in this message | | | Date | Wed, 31 Jan 2024 10:54:41 +0800 | From | Wang Jinchao <> | Subject | [PATCH] fork: Using clone_flags for legacy clone check |
| |
In the current implementation of clone(), there is a line that initializes `u64 clone_flags = args->flags` at the top. This means that there is no longer a need to use args->flags for the legacy clone check.
Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com> --- kernel/fork.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c index 0d944e92a43f..a6c5383288c9 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2876,8 +2876,8 @@ pid_t kernel_clone(struct kernel_clone_args *args) * here has the advantage that we don't need to have a separate helper * to check for legacy clone(). */ - if ((args->flags & CLONE_PIDFD) && - (args->flags & CLONE_PARENT_SETTID) && + if ((clone_flags & CLONE_PIDFD) && + (clone_flags & CLONE_PARENT_SETTID) && (args->pidfd == args->parent_tid)) return -EINVAL; -- 2.40.0
| |