Messages in this thread | | | Date | Wed, 31 Jan 2024 14:00:18 -0800 | From | Ricardo Neri <> | Subject | Re: [PATCH v2 1/6] sched/fair: add SD_CLUSTER in comments |
| |
On Tue, Jan 30, 2024 at 09:17:03PM +0800, alexs@kernel.org wrote: > From: Alex Shi <alexs@kernel.org> > > The SD_CLUSTER omitted in following TOPOLOGY_SD_FLAGS explaination, add > it to fill the absent.
Perhaps saying: "The description of SD_CLUSTER is missing. Add it." is sufficient.
> > Signed-off-by: Alex Shi <alexs@kernel.org> > To: linux-kernel@vger.kernel.org > To: Daniel Bristot de Oliveira <bristot@redhat.com> > To: Ben Segall <bsegall@google.com> > To: Steven Rostedt <rostedt@goodmis.org> > To: Dietmar Eggemann <dietmar.eggemann@arm.com> > To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> > To: Valentin Schneider <vschneid@redhat.com> > To: Vincent Guittot <vincent.guittot@linaro.org> > To: Juri Lelli <juri.lelli@redhat.com> > To: Peter Zijlstra <peterz@infradead.org> > To: Ingo Molnar <mingo@redhat.com> > --- > kernel/sched/topology.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 10d1391e7416..c342c52b1f34 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -1554,6 +1554,7 @@ static struct cpumask ***sched_domains_numa_masks; > * function: > * > * SD_SHARE_CPUCAPACITY - describes SMT topologies > + * SD_CLUSTER - describes Cluster topologies
This description does not really add much. Perhaps syaing "describes CPU cluster topologies". Then users can go to the definiton of SD_CLUSTER.
| |